Skip to content

refactor: Bump node-fetch from 3.2.10 to 3.3.2#10441

Merged
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:refactor/node-fetch-3.3.2
Apr 16, 2026
Merged

refactor: Bump node-fetch from 3.2.10 to 3.3.2#10441
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:refactor/node-fetch-3.3.2

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Apr 16, 2026 •
edited by coderabbitai bot
Loading

Bumps node-fetch from 3.2.10 to 3.3.2.

Changes

  • 3.3.0: Add static Response.json
  • 3.3.1: Allow URL class object as an argument for fetch()
  • 3.3.2: Remove the default connection close header

Closes #10432

Summary by CodeRabbit

  • Chores
    • Updated development dependencies for improved stability and compatibility.

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant bot commented Apr 16, 2026 •
edited
Loading

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7885080-01f9-4daa-814b-3fc61785bc42

📥 Commits

Reviewing files that changed from the base of the PR and between 163d7be and 7ec443d.

📒 Files selected for processing (2)
  • package-lock.json
  • package.json
📝 Walkthrough

Walkthrough

The node-fetch dependency was upgraded from version 3.2.10 to 3.3.2 in both package.json and package-lock.json. The lockfile was regenerated with updated integrity hashes and nested dependency entries were adjusted accordingly.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json, package-lock.json		 Updated node-fetch from 3.2.10 to 3.3.2, including lockfile regeneration with updated checksums and removal of redundant nested dependency entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lists relevant upstream changes and closes issue #10432, but does not follow the required template structure with Issue, Approach, and Tasks sections. Consider structuring the description to match the repository template with dedicated sections for Issue, Approach, and completion of applicable tasks.
Engage In Review Feedback ❓ Inconclusive Custom check requires verification of GitHub PR #10441 review feedback engagement, which is not accessible from git repository data alone. Access GitHub PR #10441 directly to review Conversation and Files Changed tabs for review comments and user engagement with feedback.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title begins with 'refactor:' prefix as required and accurately describes the dependency version bump.
Linked Issues check ✅ Passed The PR successfully updates node-fetch to v3.3.2, implementing all objectives from issue #10432 including Response.json, URL class support, and connection header fixes.
Out of Scope Changes check ✅ Passed All changes are strictly limited to updating node-fetch dependency versions in package.json and package-lock.json, with no extraneous modifications outside the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed PR contains only node-fetch dependency version update (3.2.10 to 3.3.2) with no source code modifications or security issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.2.519)
package.json

2026-04-16 23:25:22,657 [MainThread ] [ERROR] Template file not found: package.json
2026-04-16 23:25:22,681 [MainThread ] [ERROR] Template file not found: package.json
2026-04-16 23:25:22,690 [MainThread ] [ERROR] Template file not found: package.json
2026-04-16 23:25:22,835 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with package.json
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/ope

... [truncated 2547 characters] ...

ck__)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'
2026-04-16 23:25:22,893 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.10%. Comparing base (163d7be) to head (7ec443d).
⚠️ Report is 4 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha   #10441      +/-   ##
==========================================
- Coverage   92.50%   92.10%   -0.40%     
==========================================
  Files         192      192              
  Lines       16792    16792              
  Branches      234      234              
==========================================
- Hits        15533    15466      -67     
- Misses       1236     1299      +63     
- Partials       23       27       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza
Copy link
Copy Markdown
Member Author

mtrezza commented Apr 16, 2026

Closing: node-fetch 3.3.2 causes widespread test failures across Node 20/22, PostgreSQL 16/17/18, Redis, and MongoDB. Same failures on Dependabot's bot PR #10432. This upgrade requires manual investigation and code changes beyond a routine dependency bump.

@mtrezza mtrezza closed this Apr 16, 2026
@mtrezza mtrezza reopened this Apr 16, 2026
@mtrezza mtrezza merged commit f303f75 into parse-community:alpha Apr 16, 2026
30 of 44 checks passed
@mtrezza mtrezza deleted the refactor/node-fetch-3.3.2 branch April 16, 2026 23:52
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Apr 17, 2026

🎉 This change has been released in version 9.9.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

state:released-alpha Released as alpha version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtrezza @parseplatformorg